Conversation
Contributor
|
The API to seems to have changed, but I don't see it in this PR... I get this build error switching to this branch |
Contributor
|
Able to fix it relatively easy, but commenting in case you want to mention API change or take into account in semver version numbering |
Contributor
|
It seems to fix the problem and the thread count for my app is now stable over time. |
Collaborator
Author
|
Thanks for testing! The API was changed in this recent PR: #76 Btw, we don't have a changelog for this crate, I'll create one and make the release this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call to
Manager::adapters()spawns a new never-ending thread, so we have to call it just once.Related Issues
#83
Proposed Changes
Manager::adapters()Checklist