Add Journal entity support with PSR-3 compatibility by KarlsonComplete · Pull Request #83 · mesilov/bitrix24-php-lib

KarlsonComplete · 2026-02-12T19:05:04Z

.

…and `countByApplicationInstallationId`

gemini-code-assist · 2026-02-12T19:05:23Z

Summary of Changes

Hello @KarlsonComplete, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the JournalItemRepository implementation for Doctrine DBAL, transitioning from inheritance to composition for improved maintainability and testability. It also streamlines the JournalItemRepositoryInterface by removing two specific methods, deleteByApplicationInstallationId and countByApplicationInstallationId, along with their corresponding implementations and tests, thereby focusing the repository's contract and responsibilities.

Highlights

Refactored Doctrine Repository: The DoctrineDbalJournalItemRepository was refactored to use composition over inheritance, no longer extending Doctrine\ORM\EntityRepository directly. It now holds a private readonly EntityRepository instance.
Simplified Repository Interface: The JournalItemRepositoryInterface was simplified by removing the deleteByApplicationInstallationId and countByApplicationInstallationId methods.
Removed Unused Functionality: Corresponding implementations and tests for the removed repository methods were also removed from InMemoryJournalItemRepository and InMemoryJournalItemRepositoryTest.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

src/Journal/Infrastructure/Doctrine/DoctrineDbalJournalItemRepository.php
- Changed class inheritance from EntityRepository to direct implementation of JournalItemRepositoryInterface.
- Introduced a private readonly EntityRepository $repository property for managing JournalItem entities.
- Updated __construct, save, findById, and findByApplicationInstallationId methods to utilize the new $repository property.
- Removed the deleteByApplicationInstallationId and countByApplicationInstallationId methods.
src/Journal/Infrastructure/JournalItemRepositoryInterface.php
- Removed the deleteByApplicationInstallationId and countByApplicationInstallationId method declarations.
tests/Unit/Journal/Infrastructure/InMemory/InMemoryJournalItemRepository.php
- Removed the deleteByApplicationInstallationId and countByApplicationInstallationId methods.
tests/Unit/Journal/Infrastructure/InMemoryJournalItemRepositoryTest.php
- Removed the testDeleteByApplicationInstallationId and testCountByApplicationInstallationId test methods.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the DoctrineDbalJournalItemRepository to use composition over inheritance for the EntityRepository, which is a good practice for better maintainability and testability. It also removes the deleteByApplicationInstallationId and countByApplicationInstallationId methods, along with their corresponding interface definitions and unit tests. These changes are consistently applied across the codebase, indicating an intentional removal of functionality. The refactoring improves the overall structure of the repository.

KarlsonComplete · 2026-02-12T19:10:45Z

MR #73

…d implement minor code quality updates

src/Journal/Entity/JournalItem.php

src/Journal/Infrastructure/Doctrine/DoctrineDbalJournalItemRepository.php

src/Journal/Infrastructure/JournalItemRepositoryInterface.php

src/Journal/ReadModel/JournalItemReadRepository.php

src/Journal/Infrastructure/Doctrine/JournalItemReadRepository.php

src/Journal/ReadModel/JournalItemReadRepository.php

src/Journal/ValueObjects/JournalContext.php

src/Journal/Entity/JournalItem.php

camaxtly

15-02-2026

…and repository logic, and add `label` and `userId` to `JournalItem`

…ferences across codebase and tests

…atting in `JournalAdminController`, `JournalLogger`, and `JournalItemInterface`

camaxtly · 2026-03-01T14:20:54Z

src/Kernel/ValueObjects/Domain.php

 declare(strict_types=1);

-namespace Bitrix24\Lib\Bitrix24Accounts\ValueObjects;
+namespace Bitrix24\Lib\Kernel\ValueObjects;


Нейминг, перенести в Common

camaxtly · 2026-03-01T14:21:23Z

src/ApplicationInstallations/UseCase/Install/Command.php

 namespace Bitrix24\Lib\ApplicationInstallations\UseCase\Install;

-use Bitrix24\Lib\Bitrix24Accounts\ValueObjects\Domain;
+use Bitrix24\Lib\Kernel\ValueObjects\Domain;


нейминг

camaxtly · 2026-03-01T14:23:04Z

src/Journal/Controller/JournalAdminController.php

- * Developer should configure routes in their application
+ * Developer should configure routes in their application.
 */
 class JournalAdminController extends AbstractController


Будет вынесен в другой реп, сейчас выпиливаем

camaxtly · 2026-03-01T14:29:28Z

src/Journal/Docs/README.md

@@ -20,7 +20,8 @@ $factory = $container->get(JournalLoggerFactory::class);

 // Создаем логгер для конкретной установки приложения


Доку пересоздадим, когда будет итоговая архитектура журнала

camaxtly

1-03-2026

camaxtly · 2026-03-01T14:42:19Z

src/Journal/Entity/JournalItem.php

+     * PSR-3 compatible factory methods.
     */
-    public static function emergency(Uuid $applicationInstallationId, string $message, JournalContext $context): self
+    public static function emergency(string $memberId, Uuid $applicationInstallationId, string $message, string $label, ?string $userId, Context $context): self


Убрать методы или объяснить зачем они и для чего используются

camaxtly · 2026-03-01T14:44:34Z

src/Journal/Entity/LogLevel.php

- * PSR-3 compatible log level enum
+ * PSR-3 compatible log level enum.
 */
 enum LogLevel: string


Зачем? Мы можем использовать PSR-3

camaxtly · 2026-03-01T14:49:41Z

src/Journal/Infrastructure/Doctrine/DoctrineDbalJournalItemRepository.php

-    public function deleteOlderThan(CarbonImmutable $date): int
-    {
-        return $this->getEntityManager()->createQueryBuilder()
+    public function deleteOlderThan(


Очень не понятно, зачем метод и как он будет использоваться

camaxtly · 2026-03-01T14:59:47Z

src/Journal/Infrastructure/Doctrine/JournalItemReadRepository.php

+/**
+ * Read the model repository for journal items with filtering and pagination.
+ */
+readonly class JournalItemReadRepository


Репозиторий в доктрине только 1, в 2-х нет смысла. Этот "исторически" был в READmodel, а значит просто объеденить надо с текущим репохиторием

camaxtly · 2026-03-01T15:07:59Z

src/Journal/Services/JournalLogger.php

    #[\Override]
    public function log($level, string|\Stringable $message, array $context = []): void
    {
        $logLevel = $this->convertLevel($level);


Если мы на вход получаем psr-loglevel, то и преобразований не надо

camaxtly · 2026-03-01T15:08:34Z

src/Journal/Services/JournalLogger.php

    public function log($level, string|\Stringable $message, array $context = []): void
    {
        $logLevel = $this->convertLevel($level);
+        $label = $context['label'] ?? 'application.log';


"магические строки" внутри метода, выносится в константы

camaxtly · 2026-03-01T15:10:29Z

src/Journal/Services/JournalLogger.php

     * @param array<string, mixed> $context
     */
    #[\Override]
    public function log($level, string|\Stringable $message, array $context = []): void


а точно в интерфейсе есть такой метод?

camaxtly · 2026-03-01T15:11:34Z

src/Journal/Services/JournalLogger.php

 */
 class JournalLogger implements LoggerInterface
 {
    use LoggerTrait;


откуда трейт?

camaxtly · 2026-03-01T15:13:07Z

src/Journal/Services/JournalLogger.php

- * Writes log entries to the journal repository
+ * Writes log entries to the journal repository.
 */
 class JournalLogger implements LoggerInterface


Как с помощь/ этого логгера сделать $logger->info('test');

camaxtly · 2026-03-01T15:15:46Z

src/Journal/Services/JournalLoggerFactory.php

        return new JournalLogger(
+            memberId: $memberId,
            applicationInstallationId: $applicationInstallationId,
            repository: $this->repository,


Посмотреть зависимости, репозиторий и ЕМ разного уровня зависимости, по идее одного репозитория должно хватить. репо + flusher?

Remove unused repository methods deleteByApplicationInstallationId …

cf789f2

…and `countByApplicationInstallationId`

gemini-code-assist bot reviewed Feb 12, 2026

View reviewed changes

Refactor: normalize parameter naming, add missing doc punctuation, an…

e04d8b3

…d implement minor code quality updates