Skip to content

fix(config): ensure --confDir is globally respected and add integration tests#197

Open
vikram-2101 wants to merge 1 commit intometacall:masterfrom
vikram-2101:fix/confdir-path-sharing
Open

fix(config): ensure --confDir is globally respected and add integration tests#197
vikram-2101 wants to merge 1 commit intometacall:masterfrom
vikram-2101:fix/confdir-path-sharing

Conversation

@vikram-2101
Copy link
Contributor

@vikram-2101 vikram-2101 commented Mar 1, 2026

Summary

This PR fixes the configuration path propagation issue where the --confDir flag was not respected globally. Previously, some operations such as save() and logout could fall back to the default configuration directory instead of the user-provided one.


Changes

  • Ensured the configuration directory used during load() is preserved and reused by save() operations.
  • Simplified startup.ts by delegating default path handling to load().
  • Added integration tests to verify --confDir behavior.
  • Added a new test verifying logout using --confDir.
  • Improved some integration tests to avoid fragile exact string matching

Verification

  • Ran npm test in WSL.
  • Confirmed integration tests pass when using a custom --confDir.

@vikram-2101 vikram-2101 changed the title fix(config): ensure --confDir is globally respected and enable integr… fix(config): ensure --confDir is globally respected and integration tests Mar 9, 2026
@vikram-2101 vikram-2101 changed the title fix(config): ensure --confDir is globally respected and integration tests fix(config): ensure --confDir is globally respected and add integration tests Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant