fix: support non-GitHub repositories in --force url parsing#211
Open
codxbrexx wants to merge 1 commit intometacall:masterfrom
Open
fix: support non-GitHub repositories in --force url parsing#211codxbrexx wants to merge 1 commit intometacall:masterfrom
--force url parsing#211codxbrexx wants to merge 1 commit intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR fixes a bug where the
--forceoption crashes when passing non-GitHub repository URLs via--addrepo. It replaces the brittle, hardcodedsplit('com/')approach with nativenew URL()parsing to make suffix generation host-agnostic and robust against any valid repository URL (GitLab, self-hosted.localor.org, etc.).Changes
src/force.tsto usenew URL()for parsing paths.getSuffixFromUrl.src/test/force.spec.tsusing Mocha to ensure any given URL is handled properly, and invalid URLs don't crash the deploy process.Resolves
Resolves #210
Testing