deprecate: mark ListAllowedValuesCommand as deprecated#245
Open
david-waltermire wants to merge 1 commit intometaschema-framework:developfrom
Open
deprecate: mark ListAllowedValuesCommand as deprecated#245david-waltermire wants to merge 1 commit intometaschema-framework:developfrom
david-waltermire wants to merge 1 commit intometaschema-framework:developfrom
Conversation
The list-allowed-values functionality has been migrated to metaschema-cli. This deprecates the oscal-cli version with a notice directing users to the new command location. The import will be updated from liboscal-java to metaschema-java core in a follow-up once the metaschema-java dependency is updated.
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Deprecated(since = "3.0.0")annotation toListAllowedValuesCommand@deprecatedJavadoc tag directing users tometaschema-cli list-allowed-valuesContext
The
list-allowed-valuescommand has been migrated to metaschema-cli, making it available without requiring OSCAL-specific dependencies. The oscal-cli version is deprecated but retained for backward compatibility.The import will be updated from
dev.metaschema.oscal.lib.model.utiltodev.metaschema.core.metapath.item.nodein a follow-up once the metaschema-java dependency version is bumped.Depends on: metaschema-framework/metaschema-java#666
Test plan
mvn clean install -PCI -Prelease)Summary by CodeRabbit