mactop v2.0.6 #13
Open
mactop v2.0.6 #13
+902
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main to dev
Changed the number of available layouts from 10/6 to 17 in both the README and the in-app help text to reflect the current application state. Also added missing background color control to the help text.
The help menu can now be scrolled using j/k, arrow keys, and mouse wheel. Help text rendering is updated to show only visible lines with scroll indicators. A new helpScrollOffset global tracks scroll position, and related event handling is added for both keyboard and mouse events.
There was a problem hiding this comment.
Pull request overview
This PR adds scrollable help text functionality to mactop version 2.0.6. When the help menu content exceeds the terminal height, users can now scroll through it using keyboard (j/k, arrow keys) or mouse wheel, with visual scroll indicators.
Key Changes:
- Added help text scrolling with offset tracking and bounds checking
- Implemented keyboard and mouse wheel scroll controls for the help menu
- Updated help text to document the new scroll controls and reorganize settings information
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/app/globals.go | Added helpScrollOffset variable to track help menu scroll position |
| internal/app/events.go | Implemented keyboard (j/k, arrows) and mouse wheel event handlers for help scrolling |
| internal/app/app.go | Refactored updateHelpText() to support scrolling with viewport calculation and scroll indicators, reset scroll offset in toggleHelpMenu() |
| README.md | Updated documentation to reflect the correct number of available layouts (17) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Replaces system_profiler shell calls with direct IOKit-based enumeration for Thunderbolt, USB, storage, and GPU core count. Adds new CGo bindings and Go wrappers for native device queries, updates the profiler to use these for faster and more reliable hardware info, and introduces integration tests for the new native profiler. Also updates CLI and refines Thunderbolt bus parsing.
Introduces RDMADevice struct and extends RDMAStatus to include a list of RDMA devices. Adds logic to enumerate RDMA devices and map them to Thunderbolt buses based on network interface names. Updates CSV output and data collection to include RDMA device count and details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Modernizes hardware discovery and UI/CLI:
system_profilercalls to native IOKit forThunderbolt,USB,Storage, and fast GPU core count; adds wrappers innative_stats.goand replaces JSON parsing inprofiler.goibv_devinfo) and maps devices to TB buses; exposes inThunderboltOutputand headless CSV (RDMA_Device_Count)j/k/arrows and mouse; newhelpScrollOffsethandling inapp.go/events.go--format; README updates layout count to 17 and trims legacy deps/acksv2.0.6Written by Cursor Bugbot for commit d36e04c. This will update automatically on new commits. Configure here.