chore: AGENTS.md compliance and project standards setup#1
chore: AGENTS.md compliance and project standards setup#1
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR brings the skill-user-proxy repository into compliance with AGENTS.md rules and project standards by bootstrapping tooling, CI, and documentation infrastructure.
Changes:
- Added
agent-ruleset.jsonand generatedAGENTS.md(+CLAUDE.mdoutput config) viacompose-agentsmd. - Added
package.jsonwith Prettier formatting scripts, a.prettierrcconfig,index.jsentry point,.gitignore, and a GitHub Actionsverify.ymlworkflow. - Updated
README.mdwith Development/Setup/Verification/Formatting sections.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Defines the npm package with Prettier-based verify/format scripts |
index.js |
Adds a minimal entry point stub |
agent-ruleset.json |
Configures compose-agentsmd rule source and output targets |
README.md |
Adds development setup and workflow instructions |
AGENTS.md |
Generated agent rules document composed from shared rule source |
.prettierrc |
Prettier formatting configuration |
.gitignore |
Ignores node_modules, .DS_Store, package-lock.json, and CLAUDE.md |
.github/workflows/verify.yml |
GitHub Actions CI workflow running npm ci and npm run verify |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| node-version: lts/* | ||
| cache: "npm" | ||
| - run: npm ci |
There was a problem hiding this comment.
The workflow uses npm ci on line 18, but since package-lock.json is listed in .gitignore (and thus not committed), npm ci will fail because it strictly requires a committed lockfile. Either change npm ci to npm install, or remove package-lock.json from .gitignore and commit the lockfile.
| - run: npm ci | |
| - run: npm install |
| "scripts": { | ||
| "verify": "npm run format:check", | ||
| "format": "prettier --write .", | ||
| "format:check": "prettier --check ." | ||
| }, |
There was a problem hiding this comment.
The verify script only runs format:check (Prettier). The AGENTS.md rules (line 125) require both formatting checks and linting to be enforced in CI, and line 126 states "Treat warnings as errors in CI." There is currently no linter configured for the JavaScript code (e.g., ESLint). Since the ruleset in this same repo mandates linting for every code repo, a linter should be added and included in the verify script.
85023d5 to
a196978
Compare
|
Rebased on latest main and consolidated with new compliance rules. This PR still adds essential Node.js project structure (package.json, .prettierrc), CI verification (npm run verify), and detailed README instructions which were missing from the latest main branch. |
|
Agent runner idle completed. Repo: metyatech/skill-user-proxy Summary: |
This PR brings the repository into compliance with AGENTS.md rules and project standards.
Changes
Verification
pm run verify passed (Prettier formatting check).
AC Mapping