Closed
Conversation
r00tifant
reviewed
Oct 22, 2024
this is compatible to musl and glibc, which it wasn't previously
Owner
|
I added the desired changes and created a new PR (see here). I will close this one. Thanks for you help! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MUSL libc, the
sockaddr_in6struct is not the same as on glibc, unfortunately, the inner structure of the struct isn't mandated by POSIX 😓Edit: But there is a "public interface", that works on both glibc and musl, thanks to @r00tifant for knowing that
I needed this for Totto16/oopetris_lobby@6de856d and OpenBrickProtocolFoundation/lobby#5 so that docker image can be built,
NOTE: after this is merged 🙏🏼 simulator needs to be updated as well, as this is a sub depedendency there and thats the main reason for updating this.