Skip to content

Conversation

@neonsoftware
Copy link

Hi @mhroth,

  • added .travis.yml, very minimal setup. Just running build.sh
  • if it's the first Travis build for your account I'm glad to help in any ways setting it up
  • the .travis.yml actually creates 2 jobs, one where GCC is installed, and one whith Clang
  • added the build continuous badge Build Status in README (it points to by branch's results, will need to be updated, of course )

I additionally had to add the use of numeric macros to print intX_t uintX_t on the various architectures on commit neonsoftware@46537ca, as old compilers throw actually an error on the use of lld.
I love that -Werror is used so I guess it was an occasion for a further improvement towards portability.
Info on the these macros here here and here.

Please let me know your opinion on any aspect, and again please feel free to demand for any change or modify it.

Cheers 👍

@neonsoftware neonsoftware changed the title Added continuous Travis-CI, building with checking with both GCC and Clang added continuous Travis-CI, building with checking with both GCC and Clang Jan 3, 2017
case 'i': printf(" %d", tosc_getNextInt32(osc)); break;
case 'h': printf(" %lld", tosc_getNextInt64(osc)); break;
case 't': printf(" %lld", tosc_getNextTimetag(osc)); break;
case 'h': printf(" %" PRId64, tosc_getNextInt64(osc)); break; // PRId64 chooses corrent format (ld,lld,..)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of application do you have such that "old compilers" (which apparently don't support C99) are necessary?

Copy link
Author

@neonsoftware neonsoftware Jan 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI, for example, it's a modern and recent system, although the default compiler installed there is clang 3.4 (latest clang version is ), which would not pass the compilation with -Werror.

Moreover, for the not supporting c99, PRId64 and #include <inttypes.h> are in c99, and the original problem is about warning with printing int64_t and uint64_t with an %lld, which the compiler might do with good intention, as being long long int its not always the case for those. more details
PRId64 and PRIi64 are c99 and will always place the right format, but please correct me if I'm wrong or let me know for any other use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants