Update MutuallyHuman esp-idf changes to esp-idf v5.5.1#11
Merged
rockys-spindance merged 15 commits intomhs_changes_v5.5.1from Oct 7, 2025
Merged
Update MutuallyHuman esp-idf changes to esp-idf v5.5.1#11rockys-spindance merged 15 commits intomhs_changes_v5.5.1from
rockys-spindance merged 15 commits intomhs_changes_v5.5.1from
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
dhornacek-mh
approved these changes
Oct 6, 2025
dhornacek-mh
left a comment
There was a problem hiding this comment.
Looks good here. Thanks for all the context within the PR, nothing stands out me migration wise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a new branch with all our MutuallyHuman esp-idf changes applied to the Espressif v5.5.1 tag.
Migration Guides and notes
The top-level migration guides can be found here
https://docs.espressif.com/projects/esp-idf/en/stable/esp32/migration-guides/index.html
Note that pretty much each migration step between v5.0 and v5.5.1 updates the GCC compiler and therefore can affect warning behavior.
Specific migration points to note
Here are some of the more important changes. None requires an explicit change in our code but we highlight them here in case future maintainers run into surprising behavior:
Version rebase process
The
working_mhs_changes_v5.5.1branch was created with the following steps:release/v5branch from Espressif repo along with all the v4x and v5x tags.spindance_changes_v5.0branch. Create a squashed single patch from this HEAD vs the v5.0 tag.If there are questions about these steps, you may find Rob Hartman's more detailed notes in the v5.0 uprev PR of use. See #7
Additional Changes
spindance_changes_v5.0branch -components/json/json.mkandSpinDance_Fork_Changes.mdSpinDand_Fork_Changes.md->MutuallyHuman_Fork_Changes.mdMutuallyHuman_Fork_Changes.mdfor v5.5.1Verifying the diff of diffs
To verify that we did not lose any MH changes in the port, we did a diff of the diffs. Specifically, the two diffs are:
spindance_changes_v5.0against the v5.0 tag (you can see this conveniently in PR#7working_mhs_changes_v5.5.1against the v5.5.1 tag.SUMMARY: The only possibly functional difference is the addition of authorization checks inside
wifi_config.candwifi_scan.c.Since JWT authentication is empirically working, the addition of those checks seems safe.Here we compare diffs by feature :
Network (NW) Metrics Reporting
Protocomm BLE Connectivity Reporting
JWT Authorization for Protocomm WiFi Provisioning
WPA2 Enterprise NW Support
WiFi Provisioning Sequence Changes
Python Version Change
Testing
Spot checks of esp-idf example builds
Ensured that the following
esp-idf/examples/*projects build:Espressif component unit tests
tools/unit-test-appbut it encounters a bunch of formatting errors in many component test source files. Looks like those tests are not well supported (or have not yet been ported for the latest GCC updates).Testing with callbox-embedded projects
Built and ran all the callbox-embedded projects to ensure they still operate correctly. See the details in the associated callbox-embedded PR