There is a problem with your last page...#364
Open
firecentaur wants to merge 1 commit intomichaelbromley:masterfrom
firecentaur:master
Open
There is a problem with your last page...#364firecentaur wants to merge 1 commit intomichaelbromley:masterfrom firecentaur:master
firecentaur wants to merge 1 commit intomichaelbromley:masterfrom
firecentaur:master
Conversation
if the last page is sent to the server, there are no results listed.. this lists the second last page, so that results can be displayed. Please let me know if you disagree. PS I am using server side pagination
Owner
|
Hi, I'm not sure I totally understand. So, let's say the server has 123 items, and we list 10 per page. So with the current code: So we would display links 1 ... 13.
So we need page 13 to list the final 3 items. Does that make sense, or am I missing something ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the last page is sent to the server, there are no results listed.. this lists the second last page, so that results can be displayed. Please let me know if you disagree. PS I am using server side pagination