Add ability to pass sources prop to support multiple video qualities (fixes #67)#116
Add ability to pass sources prop to support multiple video qualities (fixes #67)#116zbuttram wants to merge 4 commits intomicnews:masterfrom
Conversation
ellell
left a comment
There was a problem hiding this comment.
LGTM!
@danmakenoise want to take a peek at this?
|
@zbuttram I'm good with it! Would you be willing to add a test for it before we merge? |
|
@danmakenoise Yeah, no problem. Would something in the Edit: Looks like I should add a check in |
|
@zbuttram Sounds good to me, thank you! |
|
Guys, will you be merging this anytime soon? Would really like this feature. |
|
@harsharora04 Sorry, I imagine that's kind of on me for putting the requested changes off for so long. Just finished it up so it should be ready to merge now. |
|
Thanks @zbuttram. |
|
Thanks, this is what i need. it worked well to me |
|
Sources can be set now, but are a bit buggy, I'm guessing it's because this wasn't merged? |
Allows the official way of adding multiple HD/SD qualities as seen here: https://support.jwplayer.com/articles/how-to-add-an-hd-quality-toggle
Also a resolution for #67
I have confirmed it works with a test build.