Open
Conversation
- New demo using azure-ai-projects SDK instead of raw OpenAI SDK - Uses DefaultAzureCredential for authentication (no API keys) - Uses responses.create() API for inference - Same evals and fine-tuning APIs as original demo - Includes README comparing both approaches Files: - sarcasm_foundry.ipynb: Main notebook - requirements.txt: azure-ai-projects, azure-identity, etc. - .env.template: Configuration template - .gitignore: Excludes .env, .venv, etc.
- Use azure-ai-projects SDK with DefaultAzureCredential (no API keys) - Use responses.create() API for inference - Simplified evals with normalized pass_threshold (0-1 scale) - Remove eval_utils.py (no longer needed) - Remove separate DistillingSarcasm_Foundry folder Changes: - sarcasm.ipynb: Complete rewrite using Foundry SDK - requirements.txt: azure-ai-projects, azure-identity - README.md: Updated documentation - .env.template: New config template - .gitignore: Updated patterns
Collaborator
|
@omkarmore83 can you instead create a new demo from this? This is such a massive rewrite and will conflict with changes I need to merge that I just made for Model Monday's (adding Ministral-3b and using Developer Tier). Your notebook changes also completely remove any output cells to illustrate what the notebook does without running it. I'd also request dropping the "Comparison with Original Demo" section from the notebook as it's nonsensical. |
Collaborator
|
Actually, my Ministral-3b and Developer Tier changes are already merged...but my points about the overhaul of the notebook remain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating distillation demo to use foundry sdk.