Skip to content

Don't add wait to queue when the queue is the one owned by the command list manager #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdwtanner merged 1 commit into from
Sep 26, 2025
Merged

Don't add wait to queue when the queue is the one owned by the command list manager #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,11 @@ namespace D3D11On12
auto* pCommandListManager = ImmCtx.GetCommandListManager(static_cast<D3D12TranslationLayer::COMMAND_LIST_TYPE>(i));
if (pCommandListManager)
{
if(pCommandListManager->GetCommandQueue() == pCommmandQueue)
{
// Don't wait on the queue owned by the command list manager. This would cause a wait to be placed before the signal, causing a deadlock.
continue;
}
UINT64 WaitValue = pResource->m_LastUsedCommandListID[i];

if (WaitValue > pCommandListManager->GetCompletedFenceValue())
Expand Down
Loading