Fixes to allow msvc /premissive- #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jenatali
approved these changes
Nov 11, 2020
Member
jenatali
left a comment
jenatali
left a comment
There was a problem hiding this comment.
Thanks for doing this, looks great minus the one tabs/spaces issue.
| #pragma once | ||
| namespace D3D12TranslationLayer | ||
| { | ||
| template<> |
Member
There was a problem hiding this comment.
You overwrote the spaces in this file with tabs. Please switch back to spaces.
Member
|
Ping @xaphier, if you're able to fix the spacing issues and sign the CLA, I'd be happy to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the circular includes and allow building with /premissive-