Map DXGI HRESULTS to D3DERR HRESULTS so that d3d9 apps can react appropriately#102
Open
Map DXGI HRESULTS to D3DERR HRESULTS so that d3d9 apps can react appropriately#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D3D9 apps don't expect to receive DXGI HRESULTS, and D3D9 doesn't know to remap them either. This meant that when the error code was bubbled up to apps, they would often crash rather than trying to handle the error more gracefully.
The particular error I've seen reported was DXGI_ERROR_DEVICE_REMOVED, but I added a few more to the mapping for good measure.