Skip to content

Conversation

@ganga1980
Copy link
Contributor

This pull request updates the event filtering logic in the in_kube_events.rb plugin to improve how Kubernetes events are processed. The main change is to pass the involved object's name to the exclusion filter, which enables more precise filtering of events by resource name in addition to namespace.

Event filtering improvements:

  • The parse_and_emit_records method now passes the involved object's name (involvedObjectName) as a parameter to KubernetesApiClient.isExcludeResourceItem, allowing exclusion checks to consider both the resource name and namespace.
  • The object's name is now assigned to a variable and reused for both filtering and record population, simplifying the code.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the Kubernetes events filtering logic by enabling filtering based on the involved object's name in addition to namespace filtering.

  • Updated parse_and_emit_records to pass the actual resource name to the exclusion filter instead of an empty string
  • Improved code reusability by storing involvedObject["name"] in a variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ganga1980 ganga1980 changed the title fix bug fix k8s events DCR filter bug Nov 19, 2025
@ganga1980 ganga1980 enabled auto-merge (squash) November 19, 2025 23:53
@ganga1980
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganga1980 ganga1980 merged commit fbcc3de into ci_prod Nov 20, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants