Fix Natvis.SimpleWrapper not forwarding FullName correctly #1525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would result in array elements in Natvis using incorrect expressions. For instance, the first array element would use the literal
[0]as expression instead of the actual element path, which is on its own meaningless.This affects a lot of other code:
VariableInformation.SizeandAddressmake use ofFullName, it's used for Natvis, and it is passed to AD7 throughDEBUG_PROPERTY_INFO.bstrFullName.Repro case
Source:
Natvis:
SimpleWrapper.FullName.array.SimpleWrapper.FullName.[0]is returned as full name instead of the expected expression((*(Wrapper(*)[1])(((array).mBuffer)+0)))[0].This should be my last PR for now, apologies for blasting them at you rapid-fire. :)