Resolves bug due to name issues of the data roles on Chart#5
Open
gillisce wants to merge 2 commits intomicrosoft:mainfrom
Open
Resolves bug due to name issues of the data roles on Chart#5gillisce wants to merge 2 commits intomicrosoft:mainfrom
gillisce wants to merge 2 commits intomicrosoft:mainfrom
Conversation
added 2 commits
September 28, 2022 14:38
|
@gillisce please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
@gillisce the command you issued was incorrect. Please try again. Examples are: and |
1 similar comment
|
@gillisce the command you issued was incorrect. Please try again. Examples are: and |
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I remove the use of DataRoles tied to the chart type and use the Data Role Names instead, this resolves an error I noticed when the recent update came out in June of 2022. The dataroles the showcase uses were outdated due to the updates made to Power BI. By leveraging the Data Role Names the showcase is able to run and allow users to test out creating their own visuals
Closes #4