Skip to content

Document container registry resource configuration #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+395 −0
Open

Document container registry resource configuration #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4607326
Initial plan
Copilot Feb 18, 2026
be6b376
Add comprehensive container registry documentation
Copilot Feb 18, 2026
5e66a10
Add container registry page to sidebar navigation
Copilot Feb 18, 2026
cd74fd3
Address review feedback: revert integrations.json, add translations, …
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/frontend/config/sidebar/docs.topics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,14 @@ export const docsTopics: StarlightSidebarTopicsUserConfig = {
ja: '証明書の構成',
},
},
{
label: 'Container registry configuration',
slug: 'app-host/container-registry',
translations: {
en: 'Container registry configuration',
ja: 'コンテナー レジストリの構成',
},
Comment on lines 782 to 785
Copy link
Member

@IEvangelist IEvangelist Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the other translations, please add them

Copy link
Contributor Author

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in cd74fd3. Added Japanese translation: 'コンテナー レジストリの構成'

Comment on lines +779 to +785
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sidebar entry for "Container registry configuration" is missing a Japanese translation. Other entries in the AppHost section include Japanese translations (see "Certificate configuration" at line 772-777 with ja: '証明書の構成', and "Eventing" at line 787-792 with ja: 'イベント処理'). Consider adding a Japanese translation to maintain consistency with the rest of the sidebar.

Copilot uses AI. Check for mistakes.
},
{
label: 'Eventing',
slug: 'app-host/eventing',
Expand Down
4 changes: 4 additions & 0 deletions src/frontend/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
onlyBuiltDependencies:
- esbuild
- sharp
Comment on lines +1 to +3
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of onlyBuiltDependencies to pnpm-workspace.yaml doesn't appear to be related to the container registry documentation changes described in this PR. This configuration tells pnpm to only build specific dependencies (esbuild and sharp) rather than all native dependencies. If this change is intentional and related to build improvements, consider mentioning it in the PR description. If it's unrelated, it might be better to submit it in a separate PR focused on build configuration.

Copilot uses AI. Check for mistakes.

overrides:
'@anthropic-ai/claude-code@<2.0.31': '>=2.0.31'
Loading
Loading