Fix docker integration code to compile and run.#482
Merged
IEvangelist merged 3 commits intomicrosoft:mainfrom Feb 26, 2026
Merged
Fix docker integration code to compile and run.#482IEvangelist merged 3 commits intomicrosoft:mainfrom
IEvangelist merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes critical compilation issues in the Docker integration documentation by correcting the PublishAsDockerComposeService API usage and fixing the AddParameterFromConfiguration API signature. The previous documentation showed these methods being called without required parameters, which would prevent the code from compiling.
Changes:
- Updated
PublishAsDockerComposeServicecalls to include the required action callback(resource, service) => { }throughout all code examples - Fixed
AddParameterFromConfigurationcalls to include both the requirednameandconfigurationKeyparameters - Added pragma warning directives to suppress experimental API warnings for container image push options and container registry APIs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IEvangelist
approved these changes
Feb 26, 2026
Member
|
Had to fix those styles, they were triggering me. 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous to this PR, the article suggested that the method is called like this:
This won't compile or run because you need to pass an action:
Plus a couple of other fixes.