Security: Fix Path Traversal in LocalCommandLineCodeExecutor #7181
+35
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a critical security vulnerability in
LocalCommandLineCodeExecutorwhere executed Python code could perform path traversal to write files outside the designatedwork_dir.Prior to this fix, an agent could execute code like
open('../../pwned.txt', 'w')to overwrite arbitrary files on the host system, potentially leading to Remote Code Execution (RCE).Changes
SECURITY_PREAMBLEthat utilizessys.addaudithook(Python 3.8+) to intercept low-level file operations (open,io.open,os.open).cwd).work_dirnow raise aPermissionError._execute_code_dont_check_setupinautogen_ext/code_executors/local/__init__.pyto prepend this security preamble to all Python code blocks before execution.