-
Notifications
You must be signed in to change notification settings - Fork 53
Generate extension methods in task namespace instead of Microsoft.DurableTask #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/fix-extension-method-namespace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+341
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
…tation Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix generated extension methods namespace placement
Generate extension methods in task namespace instead of Microsoft.DurableTask
Dec 7, 2025
Member
|
@copilot fix ci failures |
…e references Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com>
Contributor
Author
Fixed in f4c0c5e. The merge from main introduced a conflict with PR #535's XML documentation changes that wasn't resolved correctly. I've fixed the corrupted test code and updated the generator to simplify type references in XML |
…into copilot/fix-extension-method-namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Fixed merge conflict that corrupted the
Activities_ExplicitNamingtest after merging PR #535 which added XML documentation to generated code.Updated the generator to also simplify type references in XML
<see cref=""/>attributes when generating code in the same namespace as the referenced type, maintaining consistency with the method signatures and return types.All generator tests now pass successfully.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.