Add Roslyn analyzer for non-contextual logger usage in orchestrations (DURABLE0009)

[Copilot]

Orchestrations must use context.CreateReplaySafeLogger() instead of injecting ILogger directly, otherwise logs will be emitted during replay operations. This was listed as a common gotcha in #253 but lacked compile-time detection.

Changes

• New analyzer LoggerOrchestrationAnalyzer (DURABLE0009) warns when:

  • ILogger or ILogger<T> parameters appear in orchestration signatures
  • ILogger fields/properties are referenced within orchestration code paths
  • Works across Durable Functions, TaskOrchestrator, and AddOrchestratorFunc patterns

• Detection logic traverses method call chains to catch indirect usage, skips parameter references already flagged at declaration to avoid duplicate diagnostics

• Ignores legitimate cases: Activity functions, loggers created via CreateReplaySafeLogger(), non-orchestration code

Example

// ❌ Warns: DURABLE0009
[Function("MyOrchestration")]
public async Task Run(
    [OrchestrationTrigger] TaskOrchestrationContext context,
    ILogger logger)  // Non-contextual logger detected
{
    logger.LogInformation("Processing");  // Will log during replay
}

// ✅ Correct usage
[Function("MyOrchestration")]
public async Task Run([OrchestrationTrigger] TaskOrchestrationContext context)
{
    ILogger logger = context.CreateReplaySafeLogger(nameof(Run));
    logger.LogInformation("Processing");  // Only logs when not replaying
}

Test coverage includes all orchestration types, generic logger variants, field/property references, and method chains.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Roslyn Analyzer should alert against using a non-contextual logger</issue_title>
<issue_description>Originally reported by #253</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Roslyn Analyzer should alert against using a non-contextual logger #327

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.