Skip to content

Conversation

@anttix
Copy link

@anttix anttix commented Feb 7, 2025

Summary of changes

  • Introduce new settings to control orchestration client timeouts
  • Define individual timeouts for client operations that are most often used from http triggered functions / endpoints
  • Modify timeout bucketing not to align short timeouts which would be materially adjusted by the alignment

Key design choices

  • New timeout fields use TimeSpan type. This does not align with existing PartitonStartupTimeoutMinutes field but does align with how timeouts are specified in AzureStorageOrchestrationServiceSettings
  • Define separate timeouts for orchestration creation and message passing calls which are expected to be used most in latency sensitive paths such as http endpoints

Testing done

  • Tested manually with an internal client application

Feedback requested

Please review the use of TimeSpan type and overall fit and finish.

@anttix
Copy link
Author

anttix commented Feb 7, 2025

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Member

@sebastianburckhardt sebastianburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for submitting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants