Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ issues:
text: "^directive `//nolint:errorlint` should provide explanation"
source: '[=|!]= io.EOF'

- linters:
- gosec
text: "^G115: integer overflow conversion"


linters-settings:
exhaustive:
Expand Down
1 change: 0 additions & 1 deletion backup.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion backup_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion backuptar/tar.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package backuptar

Expand Down
1 change: 0 additions & 1 deletion backuptar/tar_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package backuptar

Expand Down
1 change: 0 additions & 1 deletion ea_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion file.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion fileinfo.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion fileinfo_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
13 changes: 9 additions & 4 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
module github.com/Microsoft/go-winio

go 1.21
go 1.23.0

toolchain go1.23.8

require (
github.com/sirupsen/logrus v1.9.3
golang.org/x/sys v0.10.0
golang.org/x/tools v0.11.0
golang.org/x/sys v0.35.0
golang.org/x/tools v0.36.0
)

require golang.org/x/mod v0.12.0 // indirect
require (
golang.org/x/mod v0.27.0 // indirect
golang.org/x/sync v0.16.0 // indirect
)
18 changes: 10 additions & 8 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,22 +1,24 @@
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
golang.org/x/mod v0.12.0 h1:rmsUpXtvNzj340zd98LZ4KntptpfRHwpFOHG188oHXc=
golang.org/x/mod v0.12.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
golang.org/x/sync v0.3.0 h1:ftCYgMx6zT/asHUrPw8BLLscYtGznsLAnjq5RH9P66E=
golang.org/x/sync v0.3.0/go.mod h1:FU7BRWz2tNW+3quACPkgCx/L+uEAv1htQ0V83Z9Rj+Y=
golang.org/x/mod v0.27.0 h1:kb+q2PyFnEADO2IEF935ehFUXlWiNjJWtRNgBLSfbxQ=
golang.org/x/mod v0.27.0/go.mod h1:rWI627Fq0DEoudcK+MBkNkCe0EetEaDSwJJkCcjpazc=
golang.org/x/sync v0.16.0 h1:ycBJEhp9p4vXvUZNszeOq0kGTPghopOL8q0fq3vstxw=
golang.org/x/sync v0.16.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.10.0 h1:SqMFp9UcQJZa+pmYuAKjd9xq1f0j5rLcDIk0mj4qAsA=
golang.org/x/sys v0.10.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/tools v0.11.0 h1:EMCa6U9S2LtZXLAMoWiR/R8dAQFRqbAitmbJ2UKhoi8=
golang.org/x/tools v0.11.0/go.mod h1:anzJrxPjNtfgiYQYirP2CPGzGLxrH2u2QBhn6Bf3qY8=
golang.org/x/sys v0.35.0 h1:vz1N37gP5bs89s7He8XuIYXpyY0+QlsKmzipCbUtyxI=
golang.org/x/sys v0.35.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
golang.org/x/tools v0.36.0 h1:kWS0uv/zsvHEle1LbV5LE8QujrxB3wfQyxHfhOk0Qkg=
golang.org/x/tools v0.36.0/go.mod h1:WBDiHKJK8YgLHlcQPYQzNCkUxUypCaa5ZegCVutKm+s=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
1 change: 0 additions & 1 deletion hvsock.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
4 changes: 2 additions & 2 deletions hvsock_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ func TestHvSockCloseReadWriteDial(t *testing.T) {

n, err = c.Read(b)
if n != 0 {
return fmt.Errorf("server did not get EOF")
return errors.New("server did not get EOF")
}
if !errors.Is(err, io.EOF) {
return errors.New("server did not get EOF")
Expand Down Expand Up @@ -632,7 +632,7 @@ func (u testUtil) Assert(b bool, msgs ...string) {
return
}
u.T.Helper()
u.T.Fatalf(msgJoin(msgs, "failed assertion"))
u.T.Fatal(msgJoin(msgs, "failed assertion"))
}

func (u testUtil) Is(err, target error, msgs ...string) {
Expand Down
1 change: 0 additions & 1 deletion pipe.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion pipe_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
9 changes: 4 additions & 5 deletions pkg/bindfilter/bind_filter.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package bindfilter

Expand Down Expand Up @@ -109,7 +108,7 @@ func GetBindMappings(volumePath string) ([]BindMapping, error) {
}

if outBuffSize < 12 {
return nil, fmt.Errorf("invalid buffer returned")
return nil, errors.New("invalid buffer returned")
}

result := buf[:outBuffSize]
Expand Down Expand Up @@ -185,15 +184,15 @@ func decodeEntry(buffer []byte) (string, error) {

func getTargetsFromBuffer(buffer []byte, offset, count int) ([]string, error) {
if len(buffer) < offset+count*6 {
return nil, fmt.Errorf("invalid buffer")
return nil, errors.New("invalid buffer")
}

targets := make([]string, count)
for i := 0; i < count; i++ {
entryBuf := buffer[offset+i*8 : offset+i*8+8]
tgt := *(*mappingTargetEntry)(unsafe.Pointer(&entryBuf[0]))
if len(buffer) < int(tgt.TargetRootOffset)+int(tgt.TargetRootLength) {
return nil, fmt.Errorf("invalid buffer")
return nil, errors.New("invalid buffer")
}
decoded, err := decodeEntry(buffer[tgt.TargetRootOffset : tgt.TargetRootOffset+tgt.TargetRootLength])
if err != nil {
Expand Down Expand Up @@ -259,7 +258,7 @@ func getFinalPath(pth string) (string, error) {

func getBindMappingFromBuffer(buffer []byte, entry mappingEntry) (BindMapping, error) {
if len(buffer) < int(entry.VirtRootOffset)+int(entry.VirtRootLength) {
return BindMapping{}, fmt.Errorf("invalid buffer")
return BindMapping{}, errors.New("invalid buffer")
}

src, err := decodeEntry(buffer[entry.VirtRootOffset : entry.VirtRootOffset+entry.VirtRootLength])
Expand Down
1 change: 0 additions & 1 deletion pkg/bindfilter/bind_filter_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package bindfilter

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/eventdata.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/eventopt.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/fieldopt.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etw

Expand Down
2 changes: 0 additions & 2 deletions pkg/etw/newprovider.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//go:build windows && (amd64 || arm64 || 386)
// +build windows
// +build amd64 arm64 386

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/newprovider_unsupported.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows && arm
// +build windows,arm

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/provider.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/provider_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/providerglobal.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etw

Expand Down
2 changes: 0 additions & 2 deletions pkg/etw/ptr64_32.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//go:build windows && (386 || arm)
// +build windows
// +build 386 arm

package etw

Expand Down
2 changes: 0 additions & 2 deletions pkg/etw/ptr64_64.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//go:build windows && (amd64 || arm64)
// +build windows
// +build amd64 arm64

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/sample/main_other.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package main

Expand Down
1 change: 0 additions & 1 deletion pkg/etw/sample/main_windows.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

// Shows a sample usage of the ETW logging package.
package main
Expand Down
2 changes: 0 additions & 2 deletions pkg/etw/wrapper_32.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//go:build windows && (386 || arm)
// +build windows
// +build 386 arm

package etw

Expand Down
2 changes: 0 additions & 2 deletions pkg/etw/wrapper_64.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
//go:build windows && (amd64 || arm64)
// +build windows
// +build amd64 arm64

package etw

Expand Down
1 change: 0 additions & 1 deletion pkg/etwlogrus/hook.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etwlogrus

Expand Down
1 change: 0 additions & 1 deletion pkg/etwlogrus/hook_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package etwlogrus

Expand Down
1 change: 0 additions & 1 deletion pkg/guid/guid_nonwindows.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package guid

Expand Down
1 change: 0 additions & 1 deletion pkg/guid/guid_windows.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package guid

Expand Down
1 change: 0 additions & 1 deletion pkg/process/process.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package process

Expand Down
1 change: 0 additions & 1 deletion pkg/process/syscall.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package process

Expand Down
1 change: 0 additions & 1 deletion pkg/security/grantvmgroupaccess.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package security

Expand Down
1 change: 0 additions & 1 deletion pkg/security/grantvmgroupaccess_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package security

Expand Down
1 change: 0 additions & 1 deletion privilege.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion privileges_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion reparse.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion sd.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion sd_test.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package winio

Expand Down
1 change: 0 additions & 1 deletion tools/etw-provider-gen/main_others.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build !windows
// +build !windows

package main

Expand Down
1 change: 0 additions & 1 deletion tools/etw-provider-gen/main_windows.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
//go:build windows
// +build windows

package main

Expand Down
Loading
Loading