Fix win32File.socket flag and add TestHvSockFlagIsSet #339
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Signed-off-by: maishivamhoo123 <maishivamhoo@gmail.com>
maishivamhoo123
force-pushed
the
fix-hvsock-flag
branch
from
24845dd to
497b051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330
Description
Hyper-V sockets were previously closed using
CloseHandle, which is incorrect for socket resources according to Windows documentation. This change updateswin32File.closeHandleto correctly useclosesocketwhen the underlying handle is a socket.Changes
closeHandleinfile.goto usewindows.Closesocketiff.socketis true.TestHvSockFlagIsSettohvsock_test.goto verify thatHvsockConnandHvsockListenercorrectly set thesocketflag, ensuring the correct close path is taken.