Clarify Node version requirements#1035
Open
ecraig12345 wants to merge 2 commits intomicrosoft:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lage v2 was originally intended to continue working with Node 14 with a flag, but this drifted over time because it turns out yarn v4 doesn't enforce
engines... The required version if using Azure blob storage had particularly drifted (as high as 20) due to the Azure SDK's refusal to follow semver and releasing breakingengineschanges in minors.This PR adds an explicit
engines.noderequirement of>=16.14.0, and adds a plugin I wrote to enforce it. However, as a compromise with the@azure/*packages, I downgraded those to the newest version compatible with Node 18 (instead of 20 in the latest versions)--so Node 18 is required if using Azure blob storage for caching. (From limited local testing, it appears that the bundle parses properly with Node 16.)