Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates all @microsoft/live-share* packages from 2.0.0-internal.14 to 2.0.0-internal.15, widens the Fluid Framework peer/dev dependency range from >=2.40 <2.90 to >=2.40 <2.100, upgrades Vite and related tooling across all samples, and drops Node 18 support from CI in favour of Node 20.
Changes:
- Version bump of all
@microsoft/live-share*packages to2.0.0-internal.15and widening Fluid framework ranges to<2.100across all packages and samples. - Tooling upgrades in samples:
vite^4 → ^6.1.7and@vitejs/plugin-react^3 → ^5.1.4. - CI Node matrix changed from
[18.x, 22.x]to[20.x, 22.x]; a bug fix removing a leading space from the--ignore-scriptsnpm argument is also included.
Reviewed changes
Copilot reviewed 35 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/live-share/package.json |
Version bumped to 2.0.0-internal.15; Fluid dependency ranges widened to <2.100 |
packages/live-share-canvas/package.json |
Version bumped; Fluid ranges widened |
packages/live-share-media/package.json |
Version bumped; Fluid ranges widened |
packages/live-share-react/package.json |
Version bumped; Fluid ranges widened |
packages/live-share-acs/package.json |
Version bumped |
samples/javascript/*/package.json (8 files) |
@microsoft/live-share* bumped to .15; vite ^6.1.7, @vitejs/plugin-react ^5.1.4; Fluid ranges widened |
samples/typescript/*/package.json (10 files) |
Same as JS samples |
internal/usage-test/*/package.json (3 files) |
Fluid ranges widened |
internal/test-utils/package.json |
@fluidframework/eslint-config-fluid bumped to ^8.1.0 |
internal/build-tools/update-fluid-range.js |
Default constants updated for next release cycle automation |
internal/build-tools/ensure-packages-built.js |
Bug fix: removed leading space from --ignore-scripts npm argument |
packages/live-share/src/LivePresence.ts |
Minor formatting-only change (trailing comma in generic type parameter list) |
packages/live-share/src/LiveFollowMode.ts |
Minor formatting-only change (extends clause reformatted) |
packages/live-share-media/src/LiveMediaSessionCoordinatorSuspension.ts |
Minor formatting-only change (class declaration on one line) |
.github/workflows/*.yaml (4 files) |
CI Node matrix changed from 18.x to 20.x |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jason-ha
left a comment
There was a problem hiding this comment.
Fluid changes look good. Others look good to me too (that is pretty old eslint deps).
You could adjust samples packages to use ^2.40 (or higher) for samples. You only need to use a range if the package imports from /legacy or /beta. Assuming package manager resolves all of the things well, using ^ might simplify you updates (less files to touch).
This PR updates all @microsoft/live-share* packages from 2.0.0-internal.14 to 2.0.0-internal.15, widens the Fluid Framework peer/dev dependency range from >=2.40 <2.90 to >=2.40 <2.100, upgrades Vite and related tooling across all samples, and drops Node 18 support from CI in favour of Node 20.