Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Conversation

@chschrae
Copy link
Member

No description provided.

@chschrae chschrae requested a review from robch as a code owner March 17, 2023 18:35
@jhakulin
Copy link

namespace macaroni;

Will this be the namespace we will expose to customer. Or should this be Azure.AI.something?


Refers to: src/cs/Interfaces/ICommandSystem.cs:4 in f23e159. [](commit_id = f23e159, deletion_comment = True)

@jhakulin
Copy link

jhakulin commented Mar 20, 2023

using Microsoft.CognitiveServices.Speech;

No copyrights in the files, we need to add them at some point


Refers to: src/cs/Interfaces/ICommandSystem.cs:1 in f23e159. [](commit_id = f23e159, deletion_comment = True)

@jhakulin
Copy link

internal class ConfigUiBuilder : IConfigureUiBuilder

Ui is normally all capital -> UI


Refers to: src/cs/CommandSystemBuilder/ConfigUiBuilder.cs:5 in f23e159. [](commit_id = f23e159, deletion_comment = False)

@jhakulin
Copy link

public interface ICommandSystem : IHost

All interface classes would probably benefit from descriptions describing the purpose of the class


Refers to: src/cs/Interfaces/ICommandSystem.cs:6 in f23e159. [](commit_id = f23e159, deletion_comment = False)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants