Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Conversation

@coryboyle
Copy link
Contributor

@coryboyle coryboyle commented Jun 5, 2023

Description

Please test before merging!

This is a HUGE PR that touches nearly every file in the project and converts the codebase from C# v10 to v8 to add support for .netstandard2.1 to the macaroni_core project. This version of netstandard is preferred/required by some environments like Unity3D.

Changes:

  • Added support for .netstandard2.1
  • Converted from C# v10 to C# v8:
    • Removed global usings
    • Converted global namespace to be braces wrapped
    • explicitly-typed constructors
    • generic TaskCompletionSource is now boolean-typed

Converted from C# v10 to C# v8.
@coryboyle coryboyle requested a review from robch as a code owner June 5, 2023 14:22
coryboyle and others added 28 commits June 5, 2023 10:28
Converted from C# v10 to C# v8.
…only if it is possible they need to); additional tracin
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants