Draft
Conversation
Member
Author
|
All pipelines passed: 
|
Member
Author
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
joshfree
reviewed
Nov 7, 2025
|
|
||
| ### Bugs Fixed | ||
|
|
||
| - Fixed test failures in CI for SQL commands for `BaseSqlCommand` (--server option) and `BaseDatabaseCommand` (--database option) by using `.AsRequired()` extension method for consistent validation. [[#943](https://github.com/microsoft/mcp/issues/943), [#1013](https://github.com/microsoft/mcp/issues/1013)] |
Member
There was a problem hiding this comment.
nit: if the changes end up being fixes to the tests themselves, and not to the product, maybe move these to the Other Changes section right below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the following tests failure in CI pipeline:
Azure.Mcp.Tools.Sql.UnitTests.EntraAdmin.EntraAdminListCommandTests.ExecuteAsync_ValidatesInputCorrectlyAzure.Mcp.Tools.Sql.UnitTests.Database.DatabaseUpdateCommandTests.ExecuteAsync_ValidatesRequiredParametersGitHub issue number?
#943
#1013
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline