-
Notifications
You must be signed in to change notification settings - Fork 380
Change tool names to use dash instead of underscore #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c81f8c0
d9e90fa
2d03dc5
b2984d8
25262ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| pr: 1727 | ||
| changes: | ||
| - section: "Breaking Changes" | ||
| description: "Change AzureBestPractice tool area from ai_app to ai-app and azure_bestpractices to azure-bestpractices. Consequently, `get_azure_bestpractices_ai_app` becomes `get-azure-bestpractices_ai-app` and `get_azure_bestpractices_get` becomes `get-azure-bestpractices_get`" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ namespace Azure.Mcp.Tools.AzureBestPractices; | |
|
|
||
| public class AzureBestPracticesSetup : IAreaSetup | ||
| { | ||
| public string Name => "get_azure_bestpractices"; | ||
| public string Name => "get-azure-bestpractices"; | ||
|
||
| public string Title => "Azure Best Practices"; | ||
| public CommandCategory Category => CommandCategory.RecommendedTools; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ private static string LoadEmbeddedText(string fileName) | |
|
|
||
| public override string Id => "6c29659e-406d-4b9b-8150-e3d4fd7ba31c"; | ||
|
|
||
| public override string Name => "ai_app"; | ||
| public override string Name => "ai-app"; | ||
|
||
|
|
||
| public override string Description => | ||
| @"Returns best practices and code generation guidance for building AI applications in Azure. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The area name change from "get_azure_bestpractices" to "get-azure-bestpractices" is a breaking change that must be documented in CHANGELOG.md. The full tool names are changing from "get_azure_bestpractices_" to "get-azure-bestpractices_" (note: the separator between area and command is underscore, but the area name itself now uses dashes).
This affects two tools:
The PR checklist specifically requires updating CHANGELOG.md for product changes. This breaking change should be added to the "## 2.0.0-beta.20 (Unreleased)" section under "### Breaking Changes".