Skip to content

ManagedLustre: Use dash instead of underscore #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
conniey wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

ManagedLustre: Use dash instead of underscore #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
262bacd
Use dash instead of underscore
conniey Feb 13, 2026
ce1d5ba
Add CHANGELOG entry.
conniey Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions servers/Azure.Mcp.Server/changelog-entries/1770999084484.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
pr: 1728
changes:
- section: "Breaking Changes"
description: "Change ManagedLustre group names to use dash instead of underscore. auto-blobimport, auto-blobexport, auto-import have dashes now."
6 changes: 3 additions & 3 deletions tools/Azure.Mcp.Tools.ManagedLustre/src/ManagedLustreSetup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public CommandGroup RegisterCommands(IServiceProvider serviceProvider)
var skuGet = serviceProvider.GetRequiredService<SkuGetCommand>();
sku.AddCommand(skuGet.Name, skuGet);

var autoexportJob = new CommandGroup("blob_autoexport", "Autoexport job operations for Azure Managed Lustre - Commands for creating jobs to export data from the filesystem to blob storage.");
var autoexportJob = new CommandGroup("blob-autoexport", "Autoexport job operations for Azure Managed Lustre - Commands for creating jobs to export data from the filesystem to blob storage.");
fileSystem.AddSubGroup(autoexportJob);

var autoexportJobCreate = serviceProvider.GetRequiredService<AutoexportJobCreateCommand>();
Expand All @@ -89,7 +89,7 @@ public CommandGroup RegisterCommands(IServiceProvider serviceProvider)
var autoexportJobDelete = serviceProvider.GetRequiredService<AutoexportJobDeleteCommand>();
autoexportJob.AddCommand(autoexportJobDelete.Name, autoexportJobDelete);

var autoimportJob = new CommandGroup("blob_autoimport", "Autoimport job operations for Azure Managed Lustre - Commands for creating jobs to import data from blob storage to the filesystem.");
var autoimportJob = new CommandGroup("blob-autoimport", "Autoimport job operations for Azure Managed Lustre - Commands for creating jobs to import data from blob storage to the filesystem.");
fileSystem.AddSubGroup(autoimportJob);

var autoimportJobCreate = serviceProvider.GetRequiredService<AutoimportJobCreateCommand>();
Expand All @@ -104,7 +104,7 @@ public CommandGroup RegisterCommands(IServiceProvider serviceProvider)
var autoimportJobDelete = serviceProvider.GetRequiredService<AutoimportJobDeleteCommand>();
autoimportJob.AddCommand(autoimportJobDelete.Name, autoimportJobDelete);

var blobImport = new CommandGroup("blob_import", "One-time blob import operations for Azure Managed Lustre - Commands for creating jobs to perform one-time import of data from blob storage to the filesystem.");
var blobImport = new CommandGroup("blob-import", "One-time blob import operations for Azure Managed Lustre - Commands for creating jobs to perform one-time import of data from blob storage to the filesystem.");
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the PR checklist, the CHANGELOG.md should be updated for product changes. Since this change modifies the tool names (from managedlustre_fs_blob_autoexport_* to managedlustre_fs_blob-autoexport_*, etc.), it's a breaking change that should be documented in the "Breaking Changes" section of servers/Azure.Mcp.Server/CHANGELOG.md under the "2.0.0-beta.20 (Unreleased)" section. Users relying on the old tool names will need to update their code.

Suggested change
var blobImport = new CommandGroup("blob-import", "One-time blob import operations for Azure Managed Lustre - Commands for creating jobs to perform one-time import of data from blob storage to the filesystem.");
var blobImport = new CommandGroup("blob_import", "One-time blob import operations for Azure Managed Lustre - Commands for creating jobs to perform one-time import of data from blob storage to the filesystem.");

Copilot uses AI. Check for mistakes.
fileSystem.AddSubGroup(blobImport);

var importJobCreate = serviceProvider.GetRequiredService<ImportJobCreateCommand>();
Expand Down
Loading