Skip to content

fix: Removing --costs parameter since it was removed in azqr v.3.0.0 (#1738) #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmendible wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −5
Open

fix: Removing --costs parameter since it was removed in azqr v.3.0.0 (#1738) #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions servers/Azure.Mcp.Server/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ The Azure MCP Server updates automatically by default whenever a new release com

### Bugs Fixed

- Fixed `azqr` call failing due to `costs` parameter removed in latest version. [[#1739](https://github.com/microsoft/mcp/pull/1739)]

### Other Changes

## 2.0.0-beta.19 (2026-02-12)
Expand Down
5 changes: 0 additions & 5 deletions tools/Azure.Mcp.Tools.Extension/src/Commands/AzqrCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ public override async Task<CommandResponse> ExecuteAsync(CommandContext context,
var jsonReportFilePath = $"{reportFileName}.json";
command += $" --output-name \"{reportFileName}\"";

// Azure Quick Review CLI can easily get throttle errors when scanning subscriptions with many resources with costs enabled.
// Unfortunately, getting such an error will abort the entire job and waste all the partial results.
// To reduce the chance of throttling, we disable costs reporting by default.
command += " --costs=false";

// Also generate a JSON report for users who don't have access to Excel.
command += " --json";
Comment on lines 99 to 100
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG.md file needs to be updated to document this bug fix. According to the pre-merge checklist, product changes (bug fixes) must be documented in servers/Azure.Mcp.Server/CHANGELOG.md. This change fixes a bug where the azqr command would fail with version 3.0.0 or higher due to the removed --costs flag. Consider adding an entry under "Bugs Fixed" in the unreleased section documenting this fix and referencing issue #1738.

Copilot uses AI. Check for mistakes.
Comment on lines 99 to 100
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change creates a backward compatibility concern. Removing the --costs=false flag will cause the azqr command to fail if users have azqr version 2.x or earlier installed (where the flag was still supported). Consider adding a note in the command description or error message indicating that azqr version 3.0.0 or higher is required. Alternatively, you could implement version detection to determine whether to include the flag or handle the error gracefully with a helpful message.

Copilot uses AI. Check for mistakes.

Expand Down