Feature/consolidated tools improvement#1759
Open
shashax42 wants to merge 2 commits intomicrosoft:mainfrom
Open
Feature/consolidated tools improvement#1759shashax42 wants to merge 2 commits intomicrosoft:mainfrom
shashax42 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
… consolidated tool validation Add 14 tool area setups that were present in production Program.cs but missing from the test CommandFactoryHelpers, causing consolidated tool tests to skip validation for those areas' commands. Added areas: Advisor, ApplicationInsights, AppService, AzureMigrate, Communication, Compute, ConfidentialLedger, EventHubs, FileShares, Policy, Pricing, SignalR, Speech, StorageSync. Also add new tests for ConsolidatedToolDiscoveryStrategy: - MapsAllRegisteredCommands: verifies consolidated count equals filtered source count (no unmapped commands) - WithAllAreas_HasSubstantialCommandCount: ensures >200 commands are mapped with all areas registered - AreMetadataEqual unit tests: null handling and value comparison
|
Thank you for your contribution @shashax42! We will review the pull request and get back to you soon. |
4f9ed60 to
3ad2b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes consolidated tool discovery default behavior and aligns unit test command registration with production.
ServiceStartOptions.ReadOnly == nullasfalseduring command filtering, so the default (unset) behavior does not unintentionally filter down to read-only commands.Notes for reviewers
ReadOnlydefault handling changes (null → false).dotnet test core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests -c Debug(852 tests).Relevant links
GitHub issue number?
#1759
Pre-merge Checklist
Required for All PRs
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)Not applicable — no product docs/dependency updates, and no tool surface changes beyond correcting the default option interpretation.
For MCP tool changes:
Not applicable — this PR changes consolidated discovery behavior and test infrastructure, not an individual tool implementation.
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationNot applicable.
eng/scripts/Process-PackageReadMe.ps1. See Package READMENot applicable.
/docs/fabric-commands.mdNot applicable.
.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)Not applicable.
ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsNot applicable.
Not applicable.
Not applicable.
Extra steps for Azure MCP Server tool changes:
/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdNot applicable.
crypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test PipelineNot run — unit-test scoped change. Local unit tests were run (852 tests).