Users/saars/add app insights list app traces#672
Open
xiaomi7732 wants to merge 20 commits intomicrosoft:mainfrom
Open
Users/saars/add app insights list app traces#672xiaomi7732 wants to merge 20 commits intomicrosoft:mainfrom
xiaomi7732 wants to merge 20 commits intomicrosoft:mainfrom
Conversation
xiaomi7732
commented
Oct 1, 2025
...ights/tests/Azure.Mcp.Tools.ApplicationInsights.LiveTests/ApplicationInsightsCommandTests.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a tool to ApplicationInsights for querying trace data by running KQL queries. It introduces the first piece of functionality to query user's Application Insights trace data using the azmcp_applicationinsights_apptrace_list command.
- Added new
AppTraceListCommandfor listing distributed trace metadata from Application Insights components - Implemented KQL query building service for constructing Application Insights queries
- Added service layer for executing Azure Monitor Log queries against Application Insights resources
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.ApplicationInsights/src/Commands/AppTrace/AppTraceListCommand.cs | New command implementation for listing Application Insights traces |
| tools/Azure.Mcp.Tools.ApplicationInsights/src/Services/KQLQueryBuilder.cs | KQL query builder service for constructing Application Insights queries |
| tools/Azure.Mcp.Tools.ApplicationInsights/src/Services/ApplicationInsightsService.cs | Updated service to support distributed trace listing functionality |
| tools/Azure.Mcp.Tools.ApplicationInsights/src/ApplicationInsightsSetup.cs | Registered new services and commands in DI container |
| core/Azure.Mcp.Core/src/Services/Azure/Resource/ResourceResolverService.cs | Moved ResourceResolverService to core namespace for reuse |
| servers/Azure.Mcp.Server/README.md | Updated documentation with new Application Insights trace commands |
| docs/azmcp-commands.md | Added documentation for new apptrace list command |
Comments suppressed due to low confidence (1)
tools/Azure.Mcp.Tools.ApplicationInsights/src/Commands/AppTrace/AppTraceListCommand.cs:1
- The description section contains inconsistent formatting with escaped quotes and mixed single/double quotes that could confuse users reading the help text.
// Copyright (c) Microsoft Corporation.
...tionInsights/tests/Azure.Mcp.Tools.ApplicationInsights.UnitTests/AppTraceListCommandTests.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ApplicationInsights/src/Services/KQLQueryBuilder.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ApplicationInsights/src/Services/AppLogsQueryClient.cs
Outdated
Show resolved
Hide resolved
jongio
requested changes
Oct 2, 2025
tools/Azure.Mcp.Tools.ApplicationInsights/src/Commands/AppTrace/AppTraceListCommand.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ApplicationInsights/src/Commands/AppTrace/AppTraceListCommand.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ApplicationInsights/src/Models/Query/ListTraceQueryResponse.cs
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ApplicationInsights/src/Options/ApplicationInsightsOptionDefinitions.cs
Outdated
Show resolved
Hide resolved
regexrowboat
approved these changes
Oct 3, 2025
aa242cf to
65371ee
Compare
jongio
requested changes
Oct 7, 2025
core/Azure.Mcp.Core/src/Services/Azure/Resource/IResourceResolverService.cs
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.ApplicationInsights/src/Commands/AppTrace/AppTraceListCommand.cs
Outdated
Show resolved
Hide resolved
65371ee to
b99da41
Compare
jongio
approved these changes
Oct 8, 2025
core/Azure.Mcp.Core/src/Services/Azure/Resource/IResourceResolverService.cs
Show resolved
Hide resolved
4a241f8 to
07a7760
Compare
74ddf1d to
de44200
Compare
xiaomi7732
commented
Oct 30, 2025
82a4992 to
d6dc71d
Compare
Contributor
|
Make sure to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a tool to ApplicationInsights for query the trace.
This is the first piece, and simple query tool to query user's application insights trace data by running KQL queries.
GitHub issue number?
#671
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline