Skip to content

Fix Power Pages generator installation error detection on restricted networks (UsGov systems) #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −5
Draft

Fix Power Pages generator installation error detection on restricted networks (UsGov systems) #1339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d9ece5
Initial plan
Copilot Oct 15, 2025
de9cf4d
Fix Power Pages commands registration on UsGov systems
Copilot Oct 15, 2025
d03eaa4
Revert command registration changes - keep only error detection fix
Copilot Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/client/lib/GeneratorAcquisition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,17 +104,18 @@ export class GeneratorAcquisition implements IDisposable {
fs.writeFileSync(path.join(this._ppagesGlobalPath, "package.json"), JSON.stringify(packageJson), 'utf-8');

const child = this.npm(['install']);
if (child.error) {
if (child.error || child.status !== 0) {
const errorMessage = child.error ? String(child.error) : `npm install exited with code ${child.status}`;
oneDSLoggerWrapper.getLogger().traceError(
'PowerPagesGeneratorInstallComplete',
String(child.error),
{ name: 'PowerPagesGeneratorInstallComplete', message: String(child.error) } as Error,
{ cliVersion: this._generatorVersion }, {}
errorMessage,
{ name: 'PowerPagesGeneratorInstallComplete', message: errorMessage } as Error,
{ cliVersion: this._generatorVersion, exitCode: child.status || -1 }, {}
);

this._context.showErrorMessage(vscode.l10n.t({
message: "Cannot install Power Pages generator: {0}",
args: [String(child.error)],
args: [errorMessage],
comment: ["{0} represents the error message returned from the exception"]
}));
} else {
Expand Down