Skip to content

[rush] Fix(#5552): sort additionalFilesForOperation for hashing#5629

Merged
iclanton merged 2 commits intomicrosoft:mainfrom
ericprestemon:eric.prestemon/fix-5552
Feb 18, 2026
Merged

[rush] Fix(#5552): sort additionalFilesForOperation for hashing#5629
iclanton merged 2 commits intomicrosoft:mainfrom
ericprestemon:eric.prestemon/fix-5552

Conversation

@ericprestemon
Copy link
Contributor

@ericprestemon ericprestemon commented Feb 18, 2026

Summary

Fixes #5552: sort additionalFilesForOperation to produce a stable hash for caching

WIthout this, repeated runs of rush commands that had multiple "additional files" dependencies would randomly miss cache.

This stabilizes the cache key so it always hits when it should.

Details

I considered trying to get the ordering correct in ProjectChangeAnalyzer.ts and there was some discussion in the ticket (#5552) and @dmichon-msft suggested doing it InputsSnapshot.ts was the right place. It appears to be the simplest.

How it was tested

Impacted documentation

Fixes microsoft#5552: sort additionalFilesForOperation to produce a stable hash for caching
@ericprestemon
Copy link
Contributor Author

ericprestemon commented Feb 18, 2026 via email

…-18-01-11.json

Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
@iclanton iclanton enabled auto-merge (squash) February 18, 2026 19:05
@iclanton iclanton moved this from Needs triage to In Progress in Bug Triage Feb 18, 2026
@iclanton iclanton merged commit b1bef90 into microsoft:main Feb 18, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Bug Triage Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

[rush] dependsOnAdditionalFiles with multiple entries gives inconsistent hashing

2 participants