-
Notifications
You must be signed in to change notification settings - Fork 675
chore: bump minimatch to 10.2.3 to fix vulnerability #5675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nnnnoel
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
nnnnoel:fix/minimatch-vulnerability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
common/changes/@microsoft/api-extractor/fix-minimatch-vulnerability_2026-02-27-10-51.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@microsoft/api-extractor", | ||
| "comment": "Bump minimatch version from 10.2.1 to 10.2.3", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@microsoft/api-extractor" | ||
| } |
10 changes: 10 additions & 0 deletions
10
...on/changes/@rushstack/package-extractor/fix-minimatch-vulnerability_2026-02-27-10-51.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/package-extractor", | ||
| "comment": "Bump minimatch version from 10.2.1 to 10.2.3", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@rushstack/package-extractor" | ||
| } |
10 changes: 10 additions & 0 deletions
10
...@rushstack/webpack4-localization-plugin/fix-minimatch-vulnerability_2026-02-27-10-51.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/webpack4-localization-plugin", | ||
| "comment": "Bump minimatch version from 10.2.1 to 10.2.3", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@rushstack/webpack4-localization-plugin" | ||
| } |
22 changes: 7 additions & 15 deletions
22
common/config/subspaces/build-tests-subspace/pnpm-lock.yaml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush. | ||
| { | ||
| "pnpmShrinkwrapHash": "c7fc0d748fad95ed6142faa9eaff041335b3fc17", | ||
| "pnpmShrinkwrapHash": "c395a90b30bd67a31beb1d1b08be9aecb02de265", | ||
| "preferredVersionsHash": "550b4cee0bef4e97db6c6aad726df5149d20e7d9", | ||
| "packageJsonInjectedDependenciesHash": "c79f0a961494e6e313bb0ec2c8fe0433cb6baaf5" | ||
| "packageJsonInjectedDependenciesHash": "8410b26d03a38d02cb52140340c78128eb2e5fdd" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush. | ||
| { | ||
| "pnpmShrinkwrapHash": "332ad6b0bd71bdfb6f4ae69270e34275b8dc2f1e", | ||
| "preferredVersionsHash": "93bf435032db8da4a18734f1eaa359c12ad147c1" | ||
| "pnpmShrinkwrapHash": "0778382a980762005a055ec6e76ca8cc37d447f1", | ||
| "preferredVersionsHash": "029c99bd6e65c5e1f25e2848340509811ff9753c" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is for the code owners of the package as well.
If possible, I would recommend using the semver dependency pattern for patches,
~x.x.x, instead of the exact versionx.x.xso that future reported vulnerabilities are easier to handle. Thoughts?That being said, an exact version update to
minimatchwould be great too, whatever it takes to unblock teams that are working with the vulnerability. Thanks!