Replace bad UTF-8 bytes when parsing git blame #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles bad UTF-8 bytes by replacing them with the � character, fixing output parsing for files with invalid byte sequences. This fixes microsoft#97
Contributor
|
@benjamingwynn, can you accept the Contributor License Agreement? It's possible that you already did and me pushing changes to your branch somehow caused it to reset. If so, I'm sorry for the inconvenience. I'm ready to merge this as soon as you accept the CLA, and I'm planning to ship a new release at that point. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
@debonte that should be taken care of on my end, thanks for the quick turnaround time for this PR and writing tests for it! |
debonte
approved these changes
Jul 17, 2025
Contributor
|
@benjamingwynn, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles bad UTF-8 bytes by replacing them with the � character, fixing
git blameoutput parsing for files with invalid byte sequences.This fixes #97