This repository was archived by the owner on Apr 16, 2022. It is now read-only.
avoid unchecked casts in AbstractGremlinResultReader#readProperty#256
Open
harti2006 wants to merge 1 commit intomicrosoft:masterfrom
Open
avoid unchecked casts in AbstractGremlinResultReader#readProperty#256harti2006 wants to merge 1 commit intomicrosoft:masterfrom
AbstractGremlinResultReader#readProperty#256harti2006 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Signed-off-by: André Menneken <andre@zalando.de>
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 86.21% 86.22% +0.01%
==========================================
Files 60 60
Lines 1357 1358 +1
Branches 232 232
==========================================
+ Hits 1170 1171 +1
Misses 74 74
Partials 113 113
Continue to review full report at Codecov.
|
Author
|
The changed code is already covered by some unit tests. |
|
Could a reviewer look at this in the interest of it being merged? This seems to be all that's needed for working with AWS Neptune. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small improvement of the
readPropertymethod: I replaced the unchecked cast with some more robust ones that don't rely on a specific implementation ofjava.util.Map. This allows me to use this library with Amazon Neptune and theSerializers.GRAPHSON_V1D0(org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0).The recommended
Serializers.GRAPHSON(org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV1d0) did not work in my project, because it produced the same data structure as handled in #243.Todos
Steps to Test
Serializers.GRAPHSON_V1D0Vertexclass and respectiveRepositoryrepository.saveorrepository.findAll