This repository was archived by the owner on Jun 11, 2020. It is now read-only.
Keep local references out of testDependencies#777
Open
jablko wants to merge 1 commit intomicrosoft:masterfrom
Open
Keep local references out of testDependencies#777jablko wants to merge 1 commit intomicrosoft:masterfrom
jablko wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Contributor
jablko
commented
Apr 30, 2020
sandersn
suggested changes
Jun 5, 2020
Member
sandersn
left a comment
There was a problem hiding this comment.
Can you make a test that gives an example of a package that this fixes? I don't understand what references are producing things like "./addon.pdf"
Same comment as your other PRs about moving to DefinitelyTyped-tools and adding a test.
Member
|
I'm guessing that a package's test.ts has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.