Skip to content

[Python] fix for setup.py #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 2 commits into from
Apr 16, 2025
Merged

[Python] fix for setup.py #7007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6024e6f
fix for setup.py
msyyc Apr 16, 2025
42074a0
fix for setup.py
msyyc Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/python-fix-2024-04-16-2025-3-16-12-37-31.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-client-python"
---

Fix for setup.py
18 changes: 11 additions & 7 deletions packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
from .base_serializer import BaseSerializer

VERSION_MAP = {
"msrest": "0.7.1",
"isodate": "0.6.1",
"azure-mgmt-core": "1.3.2",
"azure-core": "1.30.0",
"typing-extensions": "4.6.0",
"corehttp": "1.0.0b6",
"msrest": "0.7.1",
"isodate": "0.6.1",
"azure-mgmt-core": "1.3.2",
"azure-core": "1.30.0",
"typing-extensions": "4.6.0",
"corehttp": "1.0.0b6",
}

MIN_PYTHON_VERSION = "3.9"
Expand All @@ -34,7 +34,11 @@ class GeneralSerializer(BaseSerializer):

def serialize_setup_file(self) -> str:
template = self.env.get_template("packaging_templates/setup.py.jinja2")
params = {}
params = {
"VERSION_MAP": VERSION_MAP,
"MIN_PYTHON_VERSION": MIN_PYTHON_VERSION,
"MAX_PYTHON_VERSION": MAX_PYTHON_VERSION,
}
params.update(self.code_model.options)
return template.render(code_model=self.code_model, **params)

Expand Down
2 changes: 1 addition & 1 deletion .../http-client-python/generator/pygen/codegen/templates/packaging_templates/setup.py.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ setup(
"Programming Language :: Python",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3",
{% for version in range(min_version, max_version) %}
{% for version in range(min_version, max_version + 1) %}
"Programming Language :: Python :: 3.{{ version }}",
{% endfor %}
"License :: OSI Approved :: MIT License",
Expand Down
Loading