Skip to content

[Python] Ensure necessary model imports #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvaneck merged 4 commits into from
Aug 1, 2025
Merged

[Python] Ensure necessary model imports #8006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48e8f70
[Python] Ensure necessary model imports
pvaneck Jul 25, 2025
6b9acf4
Create typespec-internal-model-imports-2025-6-25-1-29-21.md
pvaneck Jul 25, 2025
4648d81
Update typespec-internal-model-imports-2025-6-25-1-29-21.md
pvaneck Jul 25, 2025
f176827
Merge branch 'main' into typespec-internal-model-imports
msyyc Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/typespec-internal-model-imports-2025-6-25-1-29-21.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- "@typespec/http-client-python"
---

Ensure necessary typing imports for internal models
2 changes: 1 addition & 1 deletion packages/http-client-python/generator/pygen/codegen/serializers/model_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def imports(self) -> FileImport:
)
if model.is_polymorphic:
file_import.add_submodule_import("typing", "Dict", ImportType.STDLIB)
if not model.internal and self.init_line(model):
if self.need_init(model):
file_import.add_submodule_import("typing", "overload", ImportType.STDLIB)
file_import.add_submodule_import("typing", "Mapping", ImportType.STDLIB)
file_import.add_submodule_import("typing", "Any", ImportType.STDLIB)
Expand Down
Loading