[python] add imports for readonly and constant props during msrest model generation#8319
Merged
iscai-msft merged 5 commits intomicrosoft:mainfrom Sep 2, 2025
Conversation
iscai-msft
requested review from
catalinaperalta,
kristapratico,
lmazuel,
msyyc,
swathipil,
tadelesh and
timotheeguerin
as code owners
Contributor
|
All changed packages have been documented.
Show changes
|
l0lawrence
approved these changes
Aug 28, 2025
Collaborator
|
You can try these changes here
|
msyyc
requested changes
Aug 29, 2025
Contributor
There was a problem hiding this comment.
It seems the new logic will result in unused import for msrest model file: Azure/autorest.python#3190
Update: committed a fix for this PR and code diff is expected now.
msyyc
added
the
emitter:client:python
msyyc
approved these changes
Sep 2, 2025
swathipil
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://teams.microsoft.com/l/message/19:b97d98e6d22c41e0970a1150b484d935@thread.skype/1756415317809?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1756160295820&teamName=Azure%20SDK&channelName=Language%20-%20Python&createdTime=1756415317809
Customer added the missing import manually as workaround: Azure/azure-sdk-for-python@5f1fae6#diff-3178476bc0964c5ecbc7168608d904a41b0be02f9940cc2034b74dbb355c2c31