Skip to content

Add auth handshake telemetry and record handshake duration #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MicroFish91 merged 4 commits into from
Feb 17, 2026
Merged

Add auth handshake telemetry and record handshake duration #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6535215
Add duration telemetry
MicroFish91 Feb 12, 2026
bea9051
Keep duration in seconds instead of ms
MicroFish91 Feb 12, 2026
178c670
Remove log
MicroFish91 Feb 12, 2026
4ac4788
Use measurements in telemetry
MicroFish91 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/commands/api/createContainerAppsApiProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export function createContainerAppsApiProvider(registerBranchResources: AzureRes
onDidReceiveAzureResourcesApis: registerBranchResources,
onApiRequestError: async (error: AzureResourcesApiRequestError) => {
await callWithTelemetryAndErrorHandling('hostApiRequestFailed', (actionContext: IActionContext) => {
actionContext.telemetry.properties.isActivationEvent = 'true';
actionContext.telemetry.properties.hostApiRequestErrorCode = error.code;
actionContext.telemetry.properties.hostApiRequestError = maskUserInfo(error.message, []);
ext.outputChannel.appendLog(localize('apiRequestError', 'Error: Failed to connect extension to the Azure Resources host.'));
Expand Down
8 changes: 8 additions & 0 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { registerAzureUtilsExtensionVariables } from '@microsoft/vscode-azext-az
import { registerGitHubExtensionVariables } from '@microsoft/vscode-azext-github';
import { TreeElementStateManager, callWithTelemetryAndErrorHandling, createApiProvider, createAzExtOutputChannel, createExperimentationService, registerUIExtensionVariables, type IActionContext, type apiUtils } from '@microsoft/vscode-azext-utils';
import { AzExtResourceType, type AzureResourcesExtensionApi } from '@microsoft/vscode-azureresources-api';
import { v4 as uuid } from 'uuid';
import * as vscode from 'vscode';
import { createContainerAppsApiProvider } from './commands/api/createContainerAppsApiProvider';
import { registerCommands } from './commands/registerCommands';
Expand Down Expand Up @@ -44,8 +45,15 @@ export async function activate(context: vscode.ExtensionContext, perfStats: { lo
ext.state = new TreeElementStateManager();
ext.branchDataProvider = new ContainerAppsBranchDataProvider();

const authHandshakeId = uuid();
const authHandshakeStartMs = Date.now();
activateContext.telemetry.properties.authHandshakeId = authHandshakeId;

const registerBranchResources = async (azureResourcesApis: (AzureResourcesExtensionApi | undefined)[]) => {
await callWithTelemetryAndErrorHandling('hostApiRequestSucceeded', (actionContext: IActionContext) => {
actionContext.telemetry.measurements.authHandshakeDuration = (Date.now() - authHandshakeStartMs) / 1000;
actionContext.telemetry.properties.authHandshakeId = authHandshakeId;
actionContext.telemetry.properties.isActivationEvent = 'true';
actionContext.errorHandling.rethrow = true;

const [rgApiV2] = azureResourcesApis;
Expand Down