Add changes for re running "Deploy to Container App" command by motm32 · Pull Request #999 · microsoft/vscode-azurecontainerapps

motm32 · 2025-12-10T22:57:15Z

This PR adds a couple things:

changes to the deploy to container app command to use an internal function. The command id when deploy to container app is run the first time around gets set directly to the internal command so when copilot re runs this command it goes straight into the internal command (see this rg PR for how that is done)
adds ACA list step and managed environment list steps to the confirmation view

Things to do:

update and release utils changes

nturinski · 2026-01-14T00:03:47Z

src/commands/createManagedEnvironment/ManagedEnvironmentListStep.ts


+    public confirmationViewProperty(context: T): ConfirmationViewProperty {
+        return {
+            name: "Container Apps Environment",


nit: Missed localization

nturinski · 2026-01-14T21:29:47Z

src/commands/deployContainerApp/deployContainerApp.ts

+
+    if (context.subscriptionId && node && imageSource) {
+        // If this command gets re run we only want the internal portion of the command to run, so we set the callbackid
+        context.callbackId = 'containerApps.deployContainerAppInternal';


Can you explain what this means?

If you look at the deployContainerApp it is now split into a internal and non internal portion. The internal portion does not include the pickContainerApp and subscriptionContext creation as I am doing that seperately in the copilot re run command. Thus we want to change the callbackId to go straight to the internal portion instead of the regular deployContainerApp route.

nturinski · 2026-01-14T21:30:59Z

src/commands/deployContainerApp/deployContainerApp.ts

 }
+
+function isCopilotUserInput(context: IActionContext): boolean {
+    return context.ui.constructor.name === 'CopilotUserInput';


Can you do context.ui instanceof CopilotUserInput? I think it's a more robust detection method.

I changes this but actually when debugging using instanceof won't work. Since I am setting the CopilotUserInput in the rg extension I think the instanceof won't work. I could do some more verbose checks than just the name but not sure if that is necessary.

nturinski · 2026-01-14T21:55:16Z

src/commands/registryCredentials/identity/ManagedIdentityRegistryCredentialsContext.ts

+import { type ManagedEnvironmentContext } from "../../ManagedEnvironmentContext";

-export interface ManagedIdentityRegistryCredentialsContext extends CreateAcrContext, ManagedEnvironmentRequiredContext, IContainerAppContext {
+export interface ManagedIdentityRegistryCredentialsContext extends CreateAcrContext, ManagedEnvironmentContext, IContainerAppContext {


Context loosened from ManagedEnvironmentRequiredContext → ManagedEnvironmentContext.
This is fine only if all consumers tolerate managedEnvironment being undefined. Worth a quick scan of downstream usage.

nturinski · 2026-01-14T21:55:50Z

src/commands/deployContainerApp/deployContainerApp.ts

-    wizardContext.telemetry.properties.revisionMode = item.containerApp.revisionsMode;

    const confirmationViewTitle: string = localize('summary', 'Summary');
    let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well');


Suggested change

let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well');

let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input preceding the changed input will need to change as well');

nturinski · 2026-01-14T21:56:20Z

src/commands/deployContainerApp/deployContainerApp.ts

-    if (wizardContext.ui instanceof CopilotUserInput) {
-        promptSteps.push(new OpenLoadingViewStep());
+    if (isCopilotUserInput(wizardContext)) {
        confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well');


Suggested change

confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well');

confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input preceding the modified input will need to change as well');

silentsnider-max · 2026-01-16T23:16:23Z

@copilot fix all

bwateratmsft · 2026-02-12T16:03:54Z

src/commands/deployContainerApp/deployContainerApp.ts

+function isCopilotUserInput(context: IActionContext): boolean {
+    return context.ui instanceof CopilotUserInput;


instanceof can break down if there are multiple versions of the utils package at play, which we aren't always careful about. We've had problems before with UserCancelledError. I'd recommend a canary property on CopilotUserInput, adding it if there isn't one already.

Additionally, this helps TypeScript narrow the type better:

Suggested change

function isCopilotUserInput(context: IActionContext): boolean {

return context.ui instanceof CopilotUserInput;

function isCopilotUserInput(context: IActionContext): context.ui is CopilotUserInput {

return context.ui instanceof CopilotUserInput;

bwateratmsft · 2026-02-12T16:05:32Z

src/commands/deployContainerApp/deployContainerApp.ts

+        promptSteps.push(new ManagedEnvironmentListStep(), new ContainerAppListStep());
+    }
+
+    let wizardContext: ContainerAppDeployContext = {} as ContainerAppDeployContext;


This might remove the need for the as cast:

Suggested change

let wizardContext: ContainerAppDeployContext = {} as ContainerAppDeployContext;

let wizardContext: Partial<ContainerAppDeployContext> = {};

motm32 added 3 commits December 3, 2025 10:10

initial

6179474

fix prompt step issues

6369e45

small change

a73ff7e

motm32 requested a review from a team as a code owner December 10, 2025 22:57

nturinski reviewed Jan 14, 2026

View reviewed changes

motm32 added 3 commits February 2, 2026 09:47

merge main

28ddbb7

requested changes

3124483

merge main

33b1e64

bwateratmsft reviewed Feb 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Add changes for re running "Deploy to Container App" command #999

Add changes for re running "Deploy to Container App" command #999
motm32 wants to merge 6 commits intomainfrom
meganmott/redeploy

motm32 commented Dec 10, 2025

Uh oh!

nturinski Jan 14, 2026

Uh oh!

nturinski Jan 14, 2026

Uh oh!

motm32 Feb 10, 2026 •

edited

Loading

Uh oh!

nturinski Jan 14, 2026

Uh oh!

motm32 Feb 11, 2026

Uh oh!

nturinski Jan 14, 2026

Uh oh!

nturinski Jan 14, 2026

Uh oh!

nturinski Jan 14, 2026

Uh oh!

silentsnider-max commented Jan 16, 2026

Uh oh!

bwateratmsft Feb 12, 2026

Uh oh!

bwateratmsft Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well');
	let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input preceding the changed input will need to change as well');

	confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well');
	confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input preceding the modified input will need to change as well');

		function isCopilotUserInput(context: IActionContext): boolean {
		return context.ui instanceof CopilotUserInput;

	let wizardContext: ContainerAppDeployContext = {} as ContainerAppDeployContext;
	let wizardContext: Partial<ContainerAppDeployContext> = {};

Comments

Conversation

motm32 commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

motm32 Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silentsnider-max commented Jan 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

motm32 Feb 10, 2026 •

edited

Loading