-
Notifications
You must be signed in to change notification settings - Fork 47
Fix long running tests #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix long running tests #1372
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8f31d09
Add debug
59ed5dc
Copilot first pass at fixing changes
48ae4a9
See what we are getting
b346d91
More debugging
0e4addd
Skeptics be damned
001fddb
Force fed credentials
9f89975
Sign in with AzDO and some debugging logs
3c31db4
Quack quack duck typing
6faa459
Fix name of rg
50b8f37
Remove debug console logs
0fa676a
Clean up some code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hard-coded 2000ms timeout is a potential source of test flakiness. If the tree refresh takes longer than expected (due to slow CI or other factors), the test may fail intermittently. Consider alternatives such as polling for the tree state or using an event-based approach to detect when the refresh is complete. If a hard-coded timeout is necessary, consider making it configurable via an environment variable or increasing it to a more conservative value.