Skip to content

Improve AppServicePlanListStep performance #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MicroFish91 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Improve AppServicePlanListStep performance #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4412de4
Improve perf
MicroFish91 Dec 12, 2025
01cb89c
Small fixes
MicroFish91 Dec 12, 2025
9399072
Even simpler
MicroFish91 Dec 12, 2025
47f1e06
Even simpler
MicroFish91 Dec 12, 2025
da77cbf
Use void
MicroFish91 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appservice/src/createAppService/AppServicePlanCreateStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class AppServicePlanNoCreatePermissionsStep extends AzureWizardExecuteStepWithAc
await context.ui.showWarningMessage(message, { modal: true, stepName: 'AspNoPermissions' }, selectExisting);

context.telemetry.properties.forbiddenResponse = 'SelectExistingAsp';
const step: AppServicePlanListStep = new AppServicePlanListStep(true /* suppressCreate */);
const step: AppServicePlanListStep = new AppServicePlanListStep(context, true /* suppressCreate */);
await step.prompt(context);
}

Expand Down
5 changes: 4 additions & 1 deletion appservice/src/createAppService/AppServicePlanListStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@ import { IAppServiceWizardContext } from './IAppServiceWizardContext';
export class AppServicePlanListStep extends AzureWizardPromptStep<IAppServiceWizardContext> {
private _suppressCreate: boolean | undefined;

public constructor(suppressCreate?: boolean) {
public constructor(context: IAppServiceWizardContext, suppressCreate?: boolean) {
super();
this._suppressCreate = suppressCreate;

// Start retrieving the appservice plans right away; tracks the concurrent list call in `context.plansTask`
void AppServicePlanListStep.getPlans(context);
}

public static async getPlans(context: IAppServiceWizardContext): Promise<AppServicePlan[]> {
Expand Down